New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: no-invalid-meta crash if no export assignment (refs #9534) #9698

Merged
merged 1 commit into from Dec 9, 2017

Conversation

Projects
None yet
5 participants
@platinumazure
Member

platinumazure commented Dec 8, 2017

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

See #9534.

What changes did you make? (Give an overview)

Added new lint error report for files that don't assign to module.exports, avoiding a crash that otherwise occurs later in the rule.

Is there anything you'd like reviewers to focus on?

One test had to be commented out due to #9534. Otherwise, not really.

@platinumazure

This comment has been minimized.

Show comment
Hide comment
@platinumazure

platinumazure Dec 8, 2017

Member

Hmm. Since this doesn't impact end-users (though it could impact developers/contributors?), should this be a Chore?

Member

platinumazure commented Dec 8, 2017

Hmm. Since this doesn't impact end-users (though it could impact developers/contributors?), should this be a Chore?

@gyandeeps

This comment has been minimized.

Show comment
Hide comment
@gyandeeps

gyandeeps Dec 8, 2017

Member

yes this should be a chore

Member

gyandeeps commented Dec 8, 2017

yes this should be a chore

@platinumazure platinumazure changed the title from Fix: no-invalid-meta crash if no export assignment (refs #9534) to Chore: no-invalid-meta crash if no export assignment (refs #9534) Dec 8, 2017

@platinumazure

This comment has been minimized.

Show comment
Hide comment
@platinumazure

platinumazure Dec 8, 2017

Member

@gyandeeps Fixed, this is now a Chore. Thanks!

Member

platinumazure commented Dec 8, 2017

@gyandeeps Fixed, this is now a Chore. Thanks!

/*
* Should be invalid, but will currently show as valid due to #9534.
* FIXME: Uncomment when #9534 is fixed in major release.

This comment has been minimized.

@not-an-aardvark

not-an-aardvark Dec 8, 2017

Member

Can we add a note about this to the 5.0.0 milestone so we don't forget?

@not-an-aardvark

not-an-aardvark Dec 8, 2017

Member

Can we add a note about this to the 5.0.0 milestone so we don't forget?

This comment has been minimized.

@platinumazure

platinumazure Dec 8, 2017

Member

👍, how would I go about doing that?

@platinumazure

platinumazure Dec 8, 2017

Member

👍, how would I go about doing that?

This comment has been minimized.

@kaicataldo

kaicataldo Dec 8, 2017

Member

Looks like we should make an issue to list these kinds of changes or just make an issue for the change itself.

@kaicataldo

kaicataldo Dec 8, 2017

Member

Looks like we should make an issue to list these kinds of changes or just make an issue for the change itself.

This comment has been minimized.

@not-an-aardvark

not-an-aardvark Dec 8, 2017

Member

If you look at a column on the milestone page, and then click on the "+" near the top-right of the column, it allows you to add a note with arbitrary text.

@not-an-aardvark

not-an-aardvark Dec 8, 2017

Member

If you look at a column on the milestone page, and then click on the "+" near the top-right of the column, it allows you to add a note with arbitrary text.

This comment has been minimized.

@platinumazure

platinumazure Dec 8, 2017

Member

Thanks, I've added a note. I can convert into an issue if needed.

@platinumazure

platinumazure Dec 8, 2017

Member

Thanks, I've added a note. I can convert into an issue if needed.

@platinumazure platinumazure merged commit 4564fe0 into master Dec 9, 2017

4 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@ilyavolodin ilyavolodin deleted the no-invalid-meta-fix-error branch Dec 9, 2017

@eslint eslint bot locked and limited conversation to collaborators Jun 8, 2018

@eslint eslint bot added the archived due to age label Jun 8, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.