Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix examples for no-useless-escape #9853

Merged
merged 1 commit into from Jan 17, 2018
Merged

Conversation

@koba04
Copy link
Contributor

koba04 commented Jan 17, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fix correct examples for no-useless-escape.

Currently, the correct example occurs no-useless-escape errors.
So I've fixed the examples.

Current(copy and paste from the page)

Fixed version

Actually, this is a useless escape.

Thanks!

Is there anything you'd like reviewers to focus on?

Copy link
Member

platinumazure left a comment

LGTM, thanks for contributing!

@platinumazure platinumazure merged commit 978574f into eslint:master Jan 17, 2018
5 checks passed
5 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Jan 17, 2018

Merged, thanks @koba04 for contributing! Feel free to create a new issue on the other possibly useless escape, if you like.

@koba04 koba04 deleted the koba04:patch-2 branch Jan 18, 2018
@koba04

This comment has been minimized.

Copy link
Contributor Author

koba04 commented Jan 18, 2018

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.