Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update documentation about configuration hierarchy for CLIEngine options (fixes #9526) #9855

Merged
merged 1 commit into from Jan 18, 2018

Conversation

@PiIsFour
Copy link
Contributor

PiIsFour commented Jan 17, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Added CLIEngine to the documentation under Configuration Cascading and Hierarchy to clarify the precedence of this configuration option.

Is there anything you'd like reviewers to focus on?
It's my first commit here. Tried to follow all the guides. Just mention anything I could do better.

@PiIsFour PiIsFour force-pushed the PiIsFour:issue9526 branch 2 times, most recently from 5871a1b to 5c0ffed Jan 17, 2018
Update documentation about configuration hierarchy for CLIEngine options
@PiIsFour PiIsFour force-pushed the PiIsFour:issue9526 branch from 5c0ffed to 9c4b9a9 Jan 17, 2018
Copy link
Member

platinumazure left a comment

LGTM, thanks for contributing!

@platinumazure platinumazure merged commit b96fb31 into eslint:master Jan 18, 2018
5 checks passed
5 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Jan 18, 2018

Thanks @PiIsFour!

@PiIsFour PiIsFour deleted the PiIsFour:issue9526 branch Jan 18, 2018
@PiIsFour

This comment has been minimized.

Copy link
Contributor Author

PiIsFour commented Jan 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.