Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Typo in error message when running npm #9866

Merged
merged 1 commit into from Feb 2, 2018

Conversation

@maciej-ka
Copy link
Contributor

maciej-ka commented Jan 20, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Updated an error message

Is there anything you'd like reviewers to focus on?
No

@jsf-clabot

This comment has been minimized.

Copy link

jsf-clabot commented Jan 20, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

not-an-aardvark left a comment

Thanks for the PR, but I think the original version is grammatically correct and the new version is grammatically incorrect.

  • The noun "package manager" needs an article or determiner before it (such as "your").
  • "of choice" idiom.
@maciej-ka

This comment has been minimized.

Copy link
Contributor Author

maciej-ka commented Jan 20, 2018

Thank you for valuable comment.
(or perhaps "a comment of value")

@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Jan 20, 2018

@maciej-ka Thanks for the PR!

I'd be okay with "a package manager of your choice", but I also don't see a strong need for this change. It's a little awkward as is, sure, but this doesn't seem like a significant improvement either.

@maciej-ka maciej-ka force-pushed the maciej-ka:fix-npm-error-typo branch from f4cbf88 to 0415206 Jan 20, 2018
Copy link
Member

not-an-aardvark left a comment

Looks good to me, thanks!

@platinumazure platinumazure merged commit d20f6b4 into eslint:master Feb 2, 2018
5 checks passed
5 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@maciej-ka maciej-ka deleted the maciej-ka:fix-npm-error-typo branch Feb 2, 2018
@renovate renovate bot mentioned this pull request Feb 14, 2018
This was referenced Mar 19, 2018
@renovate renovate bot mentioned this pull request Mar 23, 2018
@eslint eslint bot locked and limited conversation to collaborators Aug 3, 2018
@eslint eslint bot added the archived due to age label Aug 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.