Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix the messageId example (fixes #9889) #9892

Merged
merged 1 commit into from Jan 25, 2018
Merged

Conversation

@j-f1
Copy link
Contributor

j-f1 commented Jan 25, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes #9889.

What changes did you make? (Give an overview)

I updated the messageId example to correctly use the message API. I also made the code formatting match the rest of ESLint.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

Copy link
Contributor

betaorbust left a comment

👍

Copy link
Member

platinumazure left a comment

LGTM, thanks!

@platinumazure platinumazure merged commit 084351b into eslint:master Jan 25, 2018
5 checks passed
5 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Jan 25, 2018

Thanks @j-f1 for contributing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.