Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: no-mixed-operators - fixes #9962 #9964

Merged
merged 1 commit into from Feb 10, 2018

Conversation

@munkychop
Copy link
Contributor

munkychop commented Feb 9, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Improved documentation for no-mixed-operators rule - allowSamePrecedence option.

Is there anything you'd like reviewers to focus on?
N/A

@eslint eslint bot added the triage label Feb 9, 2018
@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Feb 9, 2018

Thanks @munkychop!

Would you mind tweaking your commit message so that it ends with "(fixes #9962)"? (Unfortunately, our commit-message status check is not yet smart enough to detect when an issue is referenced but it doesn't quite meet our preferred format.)

Copy link
Member

platinumazure left a comment

This LGTM, but I'm leaving a "request changes" to avoid accidental merging before the commit message is fixed (since our commit-message status check is giving a false positive here). Thanks!

@munkychop

This comment has been minimized.

Copy link
Contributor Author

munkychop commented Feb 9, 2018

Sure thing, I'll update that now

@munkychop munkychop force-pushed the munkychop:docs-no-mixed-operators branch from dfd1e84 to c827414 Feb 9, 2018
@munkychop munkychop changed the title Docs: no-mixed-operators - resolves #9962 Docs: no-mixed-operators - fixes #9962 Feb 9, 2018
@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Feb 9, 2018

Thanks @munkychop!

I'm sorry for being so specific but we like parentheses around the issue reference. So maybe something like "Docs: Clarify no-mixed-operators options (fixes #9962)"?

Really appreciate you sticking with this and working with us. Thanks!

@munkychop

This comment has been minimized.

Copy link
Contributor Author

munkychop commented Feb 9, 2018

Ah, I see. Sure thing.

@munkychop munkychop force-pushed the munkychop:docs-no-mixed-operators branch from c827414 to a7f747f Feb 9, 2018
@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Feb 9, 2018

Thanks @munkychop, this looks great! I'm going to just let this sit for a few hours in case any other team members want to look, but we'll probably merge this pretty soon.

Thanks for contributing and fixing our docs, we really appreciate it.

@not-an-aardvark not-an-aardvark merged commit 74fa253 into eslint:master Feb 10, 2018
5 checks passed
5 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@not-an-aardvark

This comment has been minimized.

Copy link
Member

not-an-aardvark commented Feb 10, 2018

Thanks for contributing!

This was referenced Mar 22, 2018
@renovate renovate bot mentioned this pull request Mar 23, 2018
@eslint eslint bot locked and limited conversation to collaborators Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.