New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: ecmaFeatures.impliedStrict (fixes: #227) #228
Conversation
3504dae
to
b6f5b60
Compare
@@ -75,17 +75,18 @@ describe("ecmaFeatures", function() { | |||
// Uncomment and fill in filename to focus on a single file | |||
// var filename = "jsx/invalid-matching-placeholder-in-closing-tag"; | |||
var feature = path.dirname(filename), | |||
permissiveValue = feature !== "impliedStrict", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, I think you're doing this because the implied strict tests are failing. Please revert this change and fix the tests.
The reason I changed ecma-features.js is that I don't know any errors that are silenced by strict mode. In other words, what code will make a 'non-strict' parser throw, but not a 'strict' parser? So for The other ecmaFeatures,
all solve parser errors when they are The |
Ah, I see, thanks for explaining. We should split out that case in a more obvious way, then. Maybe create an array called |
I moved the condition into |
Fair enough, thanks! |
New: ecmaFeatures.impliedStrict (fixes: #227)
ecmaFeatures.impliedStrict
.ecmaFeatures[feature] = true
throws forimpliedStrict
.