Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visitor-keys add AwaitExpression #388

Closed
wants to merge 1 commit into from
Closed

Conversation

othree
Copy link
Contributor

@othree othree commented Jul 25, 2018

I foundlib/visitor-keys.js don't have AwaitExpression

@jsf-clabot
Copy link

jsf-clabot commented Jul 25, 2018

CLA assistant check
All committers have signed the CLA.

@platinumazure
Copy link
Member

@eslint/eslint-team Is this something we need for espree? I'm a bit confused, as we also have eslint-visitor-keys.

@othree
Copy link
Contributor Author

othree commented Aug 13, 2018

I found eslint-visitor-keys after I send this PR. And eslint-visitor-keys is updated.

Not sure what is the expected structure of eslint components.
But to reduce un-synchronize issue.
I think its better for espree to require eslint-visitor-keys.

@platinumazure
Copy link
Member

@othree Thanks for the information!

I agree- it would be nice if espree could use eslint-visitor-keys. But I'm not sure whether that's possible or if there is a specific reason for espree to have its own visitor keys. That's why I've pinged the team: I don't know the answer myself, but hopefully someone else on the team will. 😄

@not-an-aardvark
Copy link
Member

Agreed, I think we should update this to start depending on eslint-visitor-keys.

@othree
Copy link
Contributor Author

othree commented Aug 15, 2018

@platinumazure I think this is just because eslint-visitor-keys is much newer than espree 😄

@othree
Copy link
Contributor Author

othree commented Sep 13, 2018

This is closed. See #389 for new approach.

@othree othree closed this Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants