fix: correct the return type of applyInlineConfig (#162)

* fix: correct the return type of `applyInlineConfig`

* wip: add type test

* wip

* wip

* wip

Author: lumirlumir

package.json

@@ -85,7 +85,7 @@
   "dependencies": {
     "@eslint/core": "^0.16.0",
     "@eslint/plugin-kit": "^0.4.0",
-    "@humanwhocodes/momoa": "^3.3.9",
+    "@humanwhocodes/momoa": "^3.3.10",
     "natural-compare": "^1.4.0"
   },
   "devDependencies": {

src/languages/json-source-code.js

@@ -20,8 +20,8 @@ import {
 //-----------------------------------------------------------------------------
 
 /**
- * @import { DocumentNode, AnyNode, Token } from "@humanwhocodes/momoa";
- * @import { SourceLocation, FileProblem, DirectiveType, RulesConfig } from "@eslint/core";
+ * @import { DocumentNode, AnyNode, Token, LocationRange } from "@humanwhocodes/momoa";
+ * @import { FileProblem, DirectiveType, RulesConfig } from "@eslint/core";
  * @import { JSONSyntaxElement } from "../types.ts";
  * @import { JSONLanguageOptions } from "./json-language.js";
  */
@@ -248,13 +248,13 @@ export class JSONSourceCode extends TextSourceCodeBase {
 	/**
 	 * Returns inline rule configurations along with any problems
 	 * encountered while parsing the configurations.
-	 * @returns {{problems:Array<FileProblem>,configs:Array<{config:{rules:RulesConfig},loc:SourceLocation}>}} Information
+	 * @returns {{problems:Array<FileProblem>,configs:Array<{config:{rules:RulesConfig},loc:LocationRange}>}} Information
 	 *      that ESLint needs to further process the rule configurations.
 	 */
 	applyInlineConfig() {
 		/** @type {Array<FileProblem>} */
 		const problems = [];
-		/** @type {Array<{config:{rules:RulesConfig},loc:SourceLocation}>} */
+		/** @type {Array<{config:{rules:RulesConfig},loc:LocationRange}>} */
 		const configs = [];
 
 		this.getInlineConfigNodes().forEach(comment => {

tests/types/types.test.ts

@@ -19,6 +19,7 @@ import type {
 	NumberNode,
 	ObjectNode,
 	StringNode,
+	LocationRange,
 } from "@humanwhocodes/momoa";
 import type { SourceLocation, SourceRange } from "@eslint/core";
 
@@ -43,6 +44,18 @@ json.configs.recommended.plugins satisfies object;
 	null as AssertAllNamesIn<RecommendedRuleName, RuleName>;
 }
 
+{
+	type ApplyInlineConfigLoc = ReturnType<
+		JSONSourceCode["applyInlineConfig"]
+	>["configs"][0]["loc"];
+
+	// Check that `applyInlineConfig`'s return type includes correct `loc` structure.
+	const loc: ApplyInlineConfigLoc = {
+		start: { line: 1, column: 1, offset: 0 },
+		end: { line: 1, column: 1, offset: 0 },
+	};
+}
+
 // Check that types are imported correctly from `@humanwhocodes/momoa`.
 ({
 	start: { line: 1, column: 1, offset: 1 },
@@ -80,6 +93,10 @@ json.configs.recommended.plugins satisfies object;
 			sourceCode.getParent(node) satisfies AnyNode | undefined;
 			sourceCode.getAncestors(node) satisfies JSONSyntaxElement[];
 			sourceCode.getText(node) satisfies string;
+			sourceCode.applyInlineConfig().configs[0].loc.start
+				.offset satisfies LocationRange["start"]["offset"];
+			sourceCode.applyInlineConfig().configs[0].loc.end
+				.offset satisfies LocationRange["end"]["offset"];
 		}
 
 		return {