Skip to content

Conversation

@sethamus
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

This PR fixes a bug in JSONSourceCode where carriage return (\r) characters were not recognized as line breaks.

What changes did you make? (Give an overview)

  • Update JSONSourceCode to recognize CR line endings.
  • Added tests to verify correct behavior for LF, CRLF, CR.

Related Issues

Fixes #159

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Oct 21, 2025
@eslintbot eslintbot added this to Triage Oct 21, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Oct 21, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage Oct 21, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Would like another review before merging.

@lumirlumir lumirlumir moved this from Triaging to Second Review Needed in Triage Oct 21, 2025
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit 0f6cf86 into eslint:main Oct 21, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted bug Something isn't working contributor pool

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Bug: recognize carriage return (\r) as a line break in JSONSourceCode

3 participants