Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Configuring Additional Lint Targets with `.eslintrc` #20

Open
wants to merge 8 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@mysticatea
Copy link
Member

commented May 11, 2019

Rendered RFC

This was separated from #13. I hope this enhancement to be on ESLint 7.0.0 line.

Summary

This proposal adds the ability to specify additional target files into configuration files. This enhancement will solve the pain that people have to use the --ext option with wanted file extensions even if they use plugins which support additional file types.

Related Issues

@not-an-aardvark
Copy link
Member

left a comment

I think this is a good idea overall. I left a few suggestions/questions.

Show resolved Hide resolved designs/2019-additional-lint-targets/README.md Outdated
Show resolved Hide resolved designs/2019-additional-lint-targets/README.md Outdated
Show resolved Hide resolved designs/2019-additional-lint-targets/README.md
Show resolved Hide resolved designs/2019-additional-lint-targets/README.md Outdated
Show resolved Hide resolved designs/2019-additional-lint-targets/README.md Outdated
Show resolved Hide resolved designs/2019-additional-lint-targets/README.md Outdated

mysticatea and others added some commits May 11, 2019

improve a bad sentence
Co-Authored-By: Teddy Katz <teddy.katz@gmail.com>
add the URL of this PR
Co-Authored-By: Teddy Katz <teddy.katz@gmail.com>

mysticatea added some commits May 11, 2019

@mysticatea

This comment has been minimized.

Copy link
Member Author

commented May 11, 2019

Thank you for the feedback! I updated this RFC.

@kaicataldo
Copy link
Member

left a comment

I have one question but overall I'm in favor of this change 👍

@kaicataldo
Copy link
Member

left a comment

Thanks for working on this!

@ljharb

ljharb approved these changes Jun 8, 2019

Copy link

left a comment

This will be very helpful for the airbnb config.

@btmills
Copy link
Member

left a comment

This makes sense and likely matches intuitive expectations. Would we plan to deprecate --ext and remove it or turn it into a no-op at some point?

@platinumazure
Copy link
Member

left a comment

Does this affect extended configs (shareable configs or plugin configs), or just direct project configs?

If this affects extended configs, are we concerned about config/plugin authors changing file overrides in their configs and potentially breaking users' linting configs?

@mysticatea

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

Would we plan to deprecate --ext and remove it or turn it into a no-op at some point?

I don't think we deprecate --ext for now because --ext .js has the role that disables adding target files of overrides entries.

Does this affect extended configs (shareable configs or plugin configs), or just direct project configs?

This affects extended configs. It's the purpose -- make providing shareable configs and plugin that verify other kinds of files than .js more comfortable.

If this affects extended configs, are we concerned about config/plugin authors changing file overrides in their configs and potentially breaking users' linting configs?

I think it's a breaking change regardless of this feature. People can use --ext option or glob patterns along with shareable configs or plugins, and updating overrides entries affects theirs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.