Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Conversation

@wsabransky
Copy link

@wsabransky wsabransky commented Sep 4, 2018

No description provided.

@jsf-clabot
Copy link

jsf-clabot commented Sep 4, 2018

CLA assistant check
All committers have signed the CLA.

@j-f1
Copy link
Contributor

j-f1 commented Sep 4, 2018

Can you add some tests for this?

@wsabransky wsabransky changed the title Support JSX fragments New: support JSX fragments (fixes #503) Sep 4, 2018
@wsabransky
Copy link
Author

@j-f1 done!

@JamesHenry
Copy link
Member

Thanks, @wsabransky!

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your test fixtures have not been picked up (you can tell because there were no changes to the jest snapshots).

You need to make sure you files end in .src.js like the other ones

@wsabransky
Copy link
Author

@JamesHenry Thanks, updated snapshots.

There is a disagreement between the TSEP and Babylon parser with the fragment fixtures. I tried upgrading babylon to @babel/parser but it didn't fix the problem. How would you like me to proceed?

@JamesHenry
Copy link
Member

JamesHenry commented Sep 25, 2018

Hi @wsabransky, I apologise for the inconvenience, but please could reopen this PR over here: https://github.com/JamesHenry/typescript-estree

The core parsing logic is now its own freestanding project. At the moment that project is identical to what this one used to be, so it should be very straightforward for you to port it over.

In terms of the babylon case, you can implement an ignore for your specs, check out the fixtures-to-test.js file (in the typescript-estree repo) for how that is done for other such cases right now.

Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants