-
-
Notifications
You must be signed in to change notification settings - Fork 74
New: support JSX fragments (fixes #503) #511
Conversation
|
Can you add some tests for this? |
b2405e9 to
8ea227b
Compare
|
@j-f1 done! |
fcaeb8c to
88995c0
Compare
|
Thanks, @wsabransky! |
JamesHenry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your test fixtures have not been picked up (you can tell because there were no changes to the jest snapshots).
You need to make sure you files end in .src.js like the other ones
|
@JamesHenry Thanks, updated snapshots. There is a disagreement between the TSEP and Babylon parser with the fragment fixtures. I tried upgrading babylon to @babel/parser but it didn't fix the problem. How would you like me to proceed? |
|
Hi @wsabransky, I apologise for the inconvenience, but please could reopen this PR over here: https://github.com/JamesHenry/typescript-estree The core parsing logic is now its own freestanding project. At the moment that project is identical to what this one used to be, so it should be very straightforward for you to port it over. In terms of the babylon case, you can implement an Thanks again! |
No description provided.