New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"nmap j gj" not working for some themes #72
Comments
|
It happens in both |
|
If click after the heading (so after any text or whitespace), I can go below. If I click on the last character, then I cannot move below it. There are no errors in the console. I've also contacted the author of |
|
Author of Sanctum here! If it happens with Primary and Sanctum, and not many others, it might have to do with |
|
It seems to be impacted by the font size. .markdown-preview-view h2,
.HyperMD-header-2,
.cm-header-2 {
font-size: var(--font-scale-3);
}--font-scale-3: 1.48rem;
--font-scale-4: 1.774rem; |
|
For others seeing this issue, it isn't a bug with the vimrc plugin, the same can be achieved by remapping manually. I'm leaving this open because this issue will most likely be seen by people who use this plugin. |
|
I think it had gotten worse with Obsidian 0.13.27. |
|
It is tracked here https://forum.obsidian.md/t/bug-vim-mode-gj-movement-command-break-with-live-preview-bullets-and-transclusion/31417/ Now also the normal h1 headings are affected, which wasn't the case before. Before it only affected other themes that set the size too high. |
First of all, thank you very much for adapting this plugin to cm6!❤️
I'm not sure if this is the right place, but I noticed something odd.
With themes like Primary or Sanctum, if
nmap j gjis in the vimrc, then I cannot navigate below a heading withjorcursor downin normal mode. In insert or visual mode it works. (In visual mode, if the mappingvmap j gjis active, then it requiresjtwo times to go below the heading.)Instead of going below the line, it goes to the end of it.
It does work with the base Obsidian theme, so I was wondering if it is up to the theme devs to fix it. This is where the headings css starts for Sanctum, for Primary I cannot link to the line, but you can find it if you search for
Headings.I tried a few things with Primary's headings css, but I couldn't get it to work.
Note that it doesn't affect upward motions (
k).The text was updated successfully, but these errors were encountered: