ISSUE-282:Macro Drupal 10 compatibility/PHP 8.1 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only query for existance)
... interface bc it makes this class abstract. And i REALLY don't need any of the other methods
DiegoPino
added
release duties
Was easy peasy...
And unmaintained. 7 Months open pull, no interaction. GPL. Do your thing
Can't find the actual reference. Maybe too tired?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #282
Drupal 10 (and 9.5)
Strawberry Field, --
Scanned on Sun, 10/22/2023 - 17:05
No known issues found.
docker exec -ti esmero-php bash -c "./vendor/bin/phpcs -p ./web/modules/contrib/strawberryfield --standard=PHPCompatibility --runtime-set testVersion 8.1"
............................................................ 60 / 96 (63%)
.................S.................. 96 / 96 (100%)
Time: 2 secs; Memory: 26MB
All good to go. Now actually testing.Y ou know that interactions of UI/UX/data code means testing manually too.