ISSUE-305: Don't use parent_top_sequence_id if the result Node is the same as the c… #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoPino
added
bug
|
@alliomeria won't merge this one yet. I know it works but only I have tested it ... |
|
And I will merge now |
|
@alliomeria this fix is provisional and deals with Objects that are children of a CWS but have Bookreader enabled directly on them instead of doing the normal thing to do. Show the viewer at the CWS side. The full / better fix in the future (but not on this module) is to allow IABookreader to use A) IIIF Content Search API OR store in the JS the actual image of each page as an index, that way we could return from search which images matched and at the IABookreader level discard results from images not being present (instead of the internal behavior of their JS which is just a page number) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aller node (the node that shows the book reader)
See #305