Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function Signature changes on Webform for composite elements #13

Open
DiegoPino opened this issue Jul 15, 2019 · 0 comments
Open

Function Signature changes on Webform for composite elements #13

DiegoPino opened this issue Jul 15, 2019 · 0 comments
Assignees
Labels
good first issue Good for newcomers question Further information is requested

Comments

@DiegoPino
Copy link
Member

DiegoPino commented Jul 15, 2019

What?

  1. For Webform 5.4
    https://www.drupal.org/node/3045851 adds two new arguments to

protected function buildCompositeElementsTable();

So now its:

protected function buildCompositeElementsTable(array $form, FormStateInterface $form_state);

  1. For Webform 5.4
    https://www.drupal.org/node/3052600
    Changes ::preCreate argument to be passed by reference

How?

  1. Just in case, check we use this (i could not find any entries.. but hey, i'm human)
  2. Totally needed. We are using this methods!
@DiegoPino DiegoPino added good first issue Good for newcomers question Further information is requested labels Jul 15, 2019
@DiegoPino DiegoPino self-assigned this Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant