Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support under rails5.1 #169

Merged
merged 3 commits into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@walf443
Copy link
Contributor

commented Mar 27, 2019

This fix is based on #167

There are many library problems on current master.
If this project drops support old Rails version, It's more easy to adopt it.

https://guides.rubyonrails.org/maintenance_policy.html

3 Security Issues
The current release series and the next most recent one will receive patches and new versions in case of a security issue.

These releases are created by taking the last released version, applying the security patches, and releasing. Those patches are then applied to the end of the x-y-stable branch. For example, a theoretical 1.2.3 security release would be built from 1.2.2, and then added to the end of 1-2-stable. This means that security releases are easy to upgrade to if you're running the latest version of Rails.

Currently included series: 5.2.Z, 5.1.Z.

So drop support under v5.1

walf443 added some commits Mar 27, 2019

@walf443 walf443 changed the title Fix/drop support under rails51 Drop support under rails51 Mar 27, 2019

@walf443 walf443 changed the title Drop support under rails51 Drop support under rails5.1 Mar 27, 2019

@walf443

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

Test passed !!

@walf443

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

My another motivation of Rails v5.1 is dropping support of poltergeist gem and replace it using Rails Sysem Test

That depends on phantomjs and. phantomjs is also deprecated.
ariya/phantomjs#15344

@takkanm

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Thank you for your contribution. But, I would not like to drop support old Rails version in gemspec.
Because I want to allow installation as much as the possible old version.

My suggestion is to merge #168 and move Rails4.X test to Allowed Failures in travis.yml.
What do you think?

I agree with your other motivation. Please give me time to think.

@takkanm takkanm added this to the v1.x milestone Apr 2, 2019

@takkanm takkanm merged commit 19b265f into esminc:master Apr 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@walf443 walf443 deleted the walf443:fix/drop_support_under_rails51 branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.