Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop dependency caffee-rails #170

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@walf443
Copy link
Contributor

commented Mar 30, 2019

This PR drop dependency of coffee-rails gem.

phantomjs does not support ES2015 syntax, So it cannot use class syntax.

@takkanm takkanm added this to the v1.x milestone Apr 2, 2019

@walf443 walf443 force-pushed the walf443:feature/decafe branch from 4bb9387 to fbd014b Apr 3, 2019

@walf443

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

I changed rebase base branch.

@walf443

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

hmm. I can't understand why this test failed. https://travis-ci.org/esminc/adhoq/jobs/515006628

It passed on my local environments:

bundle exec --gemfile gemfiles/Gemfile-rails-4.2.x rake spec
/Users/yoshimin/.rbenv/versions/2.3.6/bin/ruby -I/Users/yoshimin/.rbenv/versions/2.3.6/lib/ruby/gems/2.3.0/gems/rspec-core-3.8.0/lib:/Users/yoshimin/.rbenv/versions/2.3.6/lib/ruby/gems/2.3.0/gems/rspec-support-3.8.0/lib /Users/yoshimin/.rbenv/versions/2.3.6/lib/ruby/gems/2.3.0/gems/rspec-core-3.8.0/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

Randomized with seed 6076
...............................

Top 10 slowest examples (12.65 seconds, 95.5% of total time):
  Golden-path: execute adhoc query Visit root, input query and click explain then we get a EXPLAIN query result
    8.19 seconds ./spec/features/execute_adhoc_query_spec.rb:36
  Golden-path: execute adhoc query Visit root, input placeholdered query and generate report then we get a report
    0.77699 seconds ./spec/features/execute_adhoc_query_spec.rb:67
  Golden-path: execute adhoc query Visit root, input query and generate report then we get a report
    0.75369 seconds ./spec/features/execute_adhoc_query_spec.rb:46
  Golden-path: execute adhoc query async_execution feature is ON Visit root, input query and generate report then we get a report
    0.72198 seconds ./spec/features/execute_adhoc_query_spec.rb:110
  Golden-path: execute adhoc query async_execution feature is OFF Visit root, input query and generate report then we get a report
    0.68216 seconds ./spec/features/execute_adhoc_query_spec.rb:159
  Golden-path: execute adhoc query async_execution feature is ON Visit root, input placeholdered query and generate report then we get a report
    0.64341 seconds ./spec/features/execute_adhoc_query_spec.rb:133
  Can see database schema at editing form See database schema
    0.31256 seconds ./spec/features/show_database_schema_spec.rb:4
  Golden-path: execute adhoc query Visit root and input invalid query then we get a error message
    0.24594 seconds ./spec/features/execute_adhoc_query_spec.rb:89
  Golden-path: execute adhoc query Visit root, input invalid query and click explain then we get a error message
    0.21158 seconds ./spec/features/execute_adhoc_query_spec.rb:98
  Adhoq::GlobalVariable config.storage = [:s3, ....] should be an instance of Adhoq::Storage::S3
    0.11358 seconds ./spec/adhoq/global_variable_spec.rb:32

Top 10 slowest example groups:
  Golden-path: execute adhoc query
    1.53 seconds average (12.22 seconds / 8 examples) ./spec/features/execute_adhoc_query_spec.rb:1
  Can see database schema at editing form
    0.31285 seconds average (0.31285 seconds / 1 example) ./spec/features/show_database_schema_spec.rb:1
  Adhoq::GlobalVariable
    0.06609 seconds average (0.13218 seconds / 2 examples) ./spec/adhoq/global_variable_spec.rb:2
  Adhoq::Report
    0.05319 seconds average (0.10637 seconds / 2 examples) ./spec/models/adhoq/report_spec.rb:2
  Adhoq::Execution
    0.04285 seconds average (0.17141 seconds / 4 examples) ./spec/models/adhoq/execution_spec.rb:2
  Adhoq::Reporter::Xlsx
    0.01917 seconds average (0.01917 seconds / 1 example) ./spec/adhoq/reporter/xlsx_spec.rb:2
  Adhoq::Storage
    0.0142 seconds average (0.0568 seconds / 4 examples) ./spec/adhoq/storage_spec.rb:2
  Adhoq::Reporter::Csv
    0.01346 seconds average (0.02693 seconds / 2 examples) ./spec/adhoq/reporter/csv_spec.rb:4
  Adhoq::Reporter::Json
    0.01291 seconds average (0.02583 seconds / 2 examples) ./spec/adhoq/reporter/json_spec.rb:4
  Adhoq::Executor::ConnectionWrapper
    0.01188 seconds average (0.01188 seconds / 1 example) ./spec/adhoq/executor/connection_wrapper_spec.rb:2

Finished in 13.24 seconds (files took 3.61 seconds to load)
31 examples, 0 failures

Randomized with seed 6076

@walf443 walf443 force-pushed the walf443:feature/decafe branch from fbd014b to f32903f Apr 3, 2019

@walf443

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

I changed base on #173

@walf443 walf443 force-pushed the walf443:feature/decafe branch from f32903f to 0ae06c7 Apr 7, 2019

@walf443 walf443 force-pushed the walf443:feature/decafe branch from 0ae06c7 to 8793e6c Apr 16, 2019

@takkanm takkanm merged commit c7878ab into esminc:master Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.