Skip to content

Silence warning about unused PyIntToINTXX #107

Merged
merged 1 commit into from Oct 4, 2013

2 participants

@romuloceccon

Make the declaration of PyIntToINT32/PyIntToINT64 conditional; otherwise the compiler always warns about one of them being unused.

@romuloceccon romuloceccon Silence warning about unused PyIntToINTXX
Make the declaration of PyIntToINT32/PyIntToINT64
conditional; otherwise the compiler always warns
about one of them being unused.
343d367
@jskorpan
ESN Social Software member

Did you test this on 32 and 64 bit builds?

@romuloceccon

I tested with Ubuntu/gcc/64bit and armcc/32bit.

The patch just mimics the logic and order at https://github.com/romuloceccon/ultrajson/blob/silence_unused_PyIntToINTXX_warning/python/objToJSON.c#L581, the only place where those functions are referenced.

@jskorpan jskorpan merged commit e339f5b into esnme:master Oct 4, 2013
@romuloceccon romuloceccon deleted the romuloceccon:silence_unused_PyIntToINTXX_warning branch Oct 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.