Silence warning about unused PyIntToINTXX #107

Merged
merged 1 commit into from Oct 4, 2013

Conversation

Projects
None yet
2 participants
@romuloceccon
Contributor

romuloceccon commented Sep 26, 2013

Make the declaration of PyIntToINT32/PyIntToINT64 conditional; otherwise the compiler always warns about one of them being unused.

Silence warning about unused PyIntToINTXX
Make the declaration of PyIntToINT32/PyIntToINT64
conditional; otherwise the compiler always warns
about one of them being unused.
@jskorpan

This comment has been minimized.

Show comment
Hide comment
@jskorpan

jskorpan Sep 27, 2013

Member

Did you test this on 32 and 64 bit builds?

Member

jskorpan commented Sep 27, 2013

Did you test this on 32 and 64 bit builds?

@romuloceccon

This comment has been minimized.

Show comment
Hide comment
@romuloceccon

romuloceccon Sep 27, 2013

Contributor

I tested with Ubuntu/gcc/64bit and armcc/32bit.

The patch just mimics the logic and order at https://github.com/romuloceccon/ultrajson/blob/silence_unused_PyIntToINTXX_warning/python/objToJSON.c#L581, the only place where those functions are referenced.

Contributor

romuloceccon commented Sep 27, 2013

I tested with Ubuntu/gcc/64bit and armcc/32bit.

The patch just mimics the logic and order at https://github.com/romuloceccon/ultrajson/blob/silence_unused_PyIntToINTXX_warning/python/objToJSON.c#L581, the only place where those functions are referenced.

jskorpan added a commit that referenced this pull request Oct 4, 2013

Merge pull request #107 from romuloceccon/silence_unused_PyIntToINTXX…
…_warning

Silence warning about unused PyIntToINTXX

@jskorpan jskorpan merged commit e339f5b into esnme:master Oct 4, 2013

@romuloceccon romuloceccon deleted the romuloceccon:silence_unused_PyIntToINTXX_warning branch Oct 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment