Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[ujson] Fixing seg faults in unit tests #131

Merged
merged 1 commit into from Apr 11, 2014

Conversation

Projects
None yet
2 participants
Contributor

mvismonte commented Feb 1, 2014

  • The following unit tests were causing segfaults:
test_doubleLongDecimalIssue
test_invalidDoublePrecision
test_doublePrecisionTest
test_encodeDecimal
test_doubleLongIssue
test_encodeDecodeLongDecimal
  • I changed a constant that shouldn't be const because it can be overwritten by
    passing in a parameter (double_precision). I believe this was first introduced in #106.
  • Fixes the issue described in #129
[ujson] Fixing seg faults in unit tests
- The following unit tests were causing segfaults:
```
test_doubleLongDecimalIssue
test_invalidDoublePrecision
test_doublePrecisionTest
test_encodeDecimal
test_doubleLongIssue
test_encodeDecodeLongDecimal
```
- I changed a constant that couldn't be `const` because it can be overwritten by
  a passed in parameter

jskorpan added a commit that referenced this pull request Apr 11, 2014

Merge pull request #131 from mvismonte/fix-seg-fault
[ujson] Fixing seg faults in unit tests

@jskorpan jskorpan merged commit 73945db into esnme:master Apr 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment