Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

reserved identifier violation #19

Closed
elfring opened this Issue · 5 comments

3 participants

Markus Elfring Jonas Tärnström Markus Thurlin
Markus Elfring

I would like to point out that identifiers like "__UMCONNECTION_H___" and "__PACKETREADER_H__" do not fit to the expected naming conventions of the C/C++ language standard.
Would you like to adjust your selection for unique names?

Jonas Tärnström
Collaborator

What part of the expected naming convention of the C/C++ language standard would that be in violation of?

Markus Thurlin
Collaborator

ISO/IEC 14882-2003, Section 17.4.3.1.2 :)

Jonas Tärnström
Collaborator
Markus Elfring

I recommend to delete double underscores from identifiers like include guards in the affected header files to make them a bit more standard-compliant.

Jonas Tärnström
Collaborator

Feel free to supply a pull request for this one, as of now since it's not an issue I'm not going to fix it.

Thanks!

Jonas Tärnström jskorpan closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.