reserved identifier violation #19

Closed
elfring opened this Issue Jun 14, 2012 · 5 comments

Projects

None yet

3 participants

@elfring
elfring commented Jun 14, 2012

I would like to point out that identifiers like "__UMCONNECTION_H___" and "__PACKETREADER_H__" do not fit to the expected naming conventions of the C/C++ language standard.
Would you like to adjust your selection for unique names?

Member
jskorpan commented Oct 1, 2012

What part of the expected naming convention of the C/C++ language standard would that be in violation of?

Member
mthurlin commented Oct 1, 2012

ISO/IEC 14882-2003, Section 17.4.3.1.2 :)

Member
jskorpan commented Oct 1, 2012

Bastard : )

From: Markus Thurlin [mailto:notifications@github.com]
Sent: den 1 oktober 2012 22:14
To: esnme/ultramysql
Cc: Jonas Tärnström
Subject: Re: [ultramysql] reserved identifier violation (#19)

ISO/IEC 14882-2003, Section 17.4.3.1.2 :)


Reply to this email directly or view it on GitHubhttps://github.com/esnme/ultramysql/issues/19#issuecomment-9047896.

elfring commented Oct 3, 2012

I recommend to delete double underscores from identifiers like include guards in the affected header files to make them a bit more standard-compliant.

Member

Feel free to supply a pull request for this one, as of now since it's not an issue I'm not going to fix it.

Thanks!

@jskorpan jskorpan closed this Dec 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment