From 1f789a466ee8dc4f97c25876fd1003d334285a8c Mon Sep 17 00:00:00 2001
From: becem-gharbi <becem.gharbi@live.com>
Date: Fri, 21 Jun 2024 17:30:56 +0100
Subject: [PATCH] refactor(NVS): refactor `setString`

---
 src/NVS.cpp | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/NVS.cpp b/src/NVS.cpp
index af24784..dcedce5 100644
--- a/src/NVS.cpp
+++ b/src/NVS.cpp
@@ -78,13 +78,19 @@ namespace ESPAdmin
      */
     void NVS::setString(const char *key, const char *value) const
     {
-        esp_err_t err = nvs_set_str(_handler, key, value == nullptr ? "" : value);
+        const char *valueToSet = (value == nullptr) ? "" : value;
 
-        nvs_commit(_handler);
+        esp_err_t err = nvs_set_str(_handler, key, valueToSet);
+        if (err != ESP_OK)
+        {
+            _logger.warn("failed to write value of %s", key);
+            return;
+        }
 
+        err = nvs_commit(_handler);
         if (err != ESP_OK)
         {
-            _logger.warn("failed to write string %s", key);
+            _logger.warn("failed to commit value of %s", key);
         }
     }