From a3b19d730b6d416118bd2c917122a34142258f3a Mon Sep 17 00:00:00 2001 From: William Emfinger Date: Wed, 1 Oct 2025 13:48:00 -0500 Subject: [PATCH 1/3] chore(ci): Simplify CI to reduce inputs / complexity using latest version of action --- .github/workflows/build.yml | 1 - .github/workflows/package_main.yml | 14 -------------- 2 files changed, 15 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7bef6d3..17fd8a2 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -39,5 +39,4 @@ jobs: idf_target: ${{ env.IDF_TARGET }} idf_version: ${{ env.IDF_VERSION }} idf_component_manager: ${{ env.IDF_COMPONENT_MANAGER }} - base_ref: ${{ github.event.pull_request.base.sha }} flash_total_override: ${{ env.FLASH_TOTAL_OVERRIDE }} diff --git a/.github/workflows/package_main.yml b/.github/workflows/package_main.yml index 60a83b3..af2bc0f 100644 --- a/.github/workflows/package_main.yml +++ b/.github/workflows/package_main.yml @@ -71,29 +71,15 @@ jobs: build/flasher_args.json build/flash_args - - name: Determine base ref - if: ${{ github.event.release && github.event.action == 'published' }} - id: base - shell: bash - run: | - set -euo pipefail - # use the previous tag chronologically - prev=$(git tag --sort=-creatordate | sed -n '2p') - if [ -z "$prev" ]; then prev=$(git tag --sort=-v:refname | sed -n '2p'); fi - echo "ref=$prev" >> "$GITHUB_OUTPUT" - - name: Determine Size Delta if: ${{ github.event.release && github.event.action == 'published' }} uses: esp-cpp/esp-idf-size-delta@v1 with: app_name: ${{ env.APP_NAME }} app_path: "." - head_name: "${{ github.event.release.tag_name }}" - base_name: "${{ steps.base.outputs.ref }}" idf_target: ${{ env.IDF_TARGET }} idf_version: ${{ env.IDF_VERSION }} idf_component_manager: ${{ env.IDF_COMPONENT_MANAGER }} - base_ref: ${{ steps.base.outputs.ref }} flash_total_override: ${{ env.FLASH_TOTAL_OVERRIDE }} post_comment: 'false' From 84f672ba2f7909cbdf4ee999cf2b66ac0728b61f Mon Sep 17 00:00:00 2001 From: William Emfinger Date: Wed, 1 Oct 2025 13:58:18 -0500 Subject: [PATCH 2/3] simplify ci more --- .github/workflows/package_main.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/package_main.yml b/.github/workflows/package_main.yml index af2bc0f..5d8ac62 100644 --- a/.github/workflows/package_main.yml +++ b/.github/workflows/package_main.yml @@ -81,7 +81,6 @@ jobs: idf_version: ${{ env.IDF_VERSION }} idf_component_manager: ${{ env.IDF_COMPONENT_MANAGER }} flash_total_override: ${{ env.FLASH_TOTAL_OVERRIDE }} - post_comment: 'false' package: name: Package the binaries into an executables for Windows, MacOS, and Linux (Ubuntu) From 552a55b87fc978f17f9c367cdfad7bb9f52e2d0a Mon Sep 17 00:00:00 2001 From: William Emfinger Date: Wed, 1 Oct 2025 13:59:08 -0500 Subject: [PATCH 3/3] fix permissions --- .github/workflows/build.yml | 3 --- .github/workflows/static_analysis.yml | 3 --- 2 files changed, 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 17fd8a2..aa7ffcf 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -16,9 +16,6 @@ jobs: runs-on: ubuntu-latest - permissions: - issues: write - steps: - name: Checkout repo uses: actions/checkout@v5 diff --git a/.github/workflows/static_analysis.yml b/.github/workflows/static_analysis.yml index 4d442d6..05a4260 100644 --- a/.github/workflows/static_analysis.yml +++ b/.github/workflows/static_analysis.yml @@ -11,9 +11,6 @@ jobs: static_analysis: runs-on: ubuntu-latest - permissions: - issues: write - steps: - name: Checkout repo uses: actions/checkout@v5