Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional UART/Serial features #102

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Additional UART/Serial features #102

merged 1 commit into from
Jul 13, 2022

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jul 13, 2022

This adds some more features to our serial peripheral driver

  • interrupts for rx-fifo, tx-fifo and at-cmd
  • option to configure the rx-fifo threshold
  • option to configure settings for the at-cmd detection
  • one sample for each chip showing most of the new features (tx-fifo interrupt isn't too exciting to demo - so it's not used)

@bjoernQ bjoernQ requested a review from jessebraham July 13, 2022 16:10
jessebraham
jessebraham approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, looks good to me. Thanks for this!

@jessebraham jessebraham merged commit 35a5849 into esp-rs:main Jul 13, 2022
@bjoernQ bjoernQ deleted the feature/uart-interrupts branch October 27, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernQ @jessebraham