Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uninit section to bl and mv linker scripts to match db #246

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

9names
Copy link
Contributor

@9names 9names commented Nov 3, 2022

Probably should have done this as part of #175
This PR adds the .uninit section to the linker script for both bootloader modes to mirror the one provided by the cortex-m crate and match what is currently present in the direct-boot linker script.
The only user of this section that I know of is defmt-rtt.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bjoernQ bjoernQ merged commit 2b15b18 into esp-rs:main Nov 3, 2022
@9names 9names deleted the bl_uninit_section branch November 4, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants