Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove pac references in hal drivers #309

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Conversation

MabezDev
Copy link
Member

  • It was easy to use the wrong type when writing a driver in esp-hal-common
  • Now the pac is completely hidden, but its internals are exposed crate-wide via peripherals.

Quite a noisy pr so we may want to merge this once the current peripheral ref pr's are merged, and make sure everyone does a rebase after.

@MabezDev MabezDev force-pushed the completely-hide-pac branch 2 times, most recently from 3e60cd1 to 8477981 Compare December 14, 2022 09:39
jessebraham and others added 2 commits December 14, 2022 13:24
* Add SHA to list of peripherals to be created

* Refactor SHA peripheral to use PeripheralRef

* Update SHA examples to get them building again
@MabezDev MabezDev merged commit 3a57eb9 into main Dec 14, 2022
@MabezDev MabezDev deleted the completely-hide-pac branch January 9, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants