Skip to content

Fix GPIO interrupts for pins > 31 - #335

Merged
bjoernQ merged 2 commits into
esp-rs:mainfrom
bjoernQ:bugfix/fix-gpio-interrupts-pins-gt-31
Jan 6, 2023
Merged

Fix GPIO interrupts for pins > 31#335
bjoernQ merged 2 commits into
esp-rs:mainfrom
bjoernQ:bugfix/fix-gpio-interrupts-pins-gt-31

Conversation

@bjoernQ

@bjoernQ bjoernQ commented Jan 6, 2023

Copy link
Copy Markdown
Contributor

Fixes #332

Took me a bit too long because I fell into a "generics" rabbit-hole

@bjoernQ
bjoernQ requested a review from MabezDev January 6, 2023 09:45

@MabezDev MabezDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a bit too long because I fell into a "generics" rabbit-hole

We've all been there :D.

Comment thread esp-hal-common/src/gpio.rs Outdated

@MabezDev MabezDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. LGTM!

@bjoernQ
bjoernQ merged commit a0b976d into esp-rs:main Jan 6, 2023
@bjoernQ
bjoernQ deleted the bugfix/fix-gpio-interrupts-pins-gt-31 branch January 6, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GPIO incorrect interrupt status for pins > 32

2 participants