Add CI checks for the esp-hal-smartled package - #436
Merged
Conversation
This does *not* verify MSRV or clippy at this time
bjoernQ
reviewed
Mar 10, 2023
| run: cd esp-hal-smartled/ && cargo +nightly check --features=esp32c6 | ||
| # Check all Xtensa targets: | ||
| - name: check (esp32) | ||
| run: cd esp-hal-smartled/ && cargo +esp check --features=esp32,esp32_40mhz |
Contributor
There was a problem hiding this comment.
doesn't matter but I think esp32_40mhz is the default?
Member
Author
There was a problem hiding this comment.
It's the default in esp32-hal, it's not enabled in esp-hal-common which is what we depend on in the esp-hal-smartled package.
Member
Author
There was a problem hiding this comment.
With that said we can probably set it as the default in esp-hal-smartled too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forgot to add this in the last PR 😁
I've excluded the MSRV and Clippy checks for now, as they're kind of a pain due to the features. We
cargo checkthe package with all features though, and verify the formatting.