Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI checks for the esp-hal-smartled package #436

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

jessebraham
Copy link
Member

Forgot to add this in the last PR 😁

I've excluded the MSRV and Clippy checks for now, as they're kind of a pain due to the features. We cargo check the package with all features though, and verify the formatting.

This does *not* verify MSRV or clippy at this time
@jessebraham jessebraham requested review from bjoernQ and MabezDev March 10, 2023 15:54
run: cd esp-hal-smartled/ && cargo +nightly check --features=esp32c6
# Check all Xtensa targets:
- name: check (esp32)
run: cd esp-hal-smartled/ && cargo +esp check --features=esp32,esp32_40mhz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't matter but I think esp32_40mhz is the default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the default in esp32-hal, it's not enabled in esp-hal-common which is what we depend on in the esp-hal-smartled package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With that said we can probably set it as the default in esp-hal-smartled too.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessebraham jessebraham merged commit 20cdf81 into esp-rs:main Mar 10, 2023
@jessebraham jessebraham deleted the fixes/ci branch March 10, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants