Fix warnings and clean up a RTC driver - #440
Merged
Merged
Conversation
bjoernQ
approved these changes
Mar 14, 2023
bjoernQ
left a comment
bjoernQ
left a comment
Contributor
There was a problem hiding this comment.
LGTM
We can re-add the functions once we choose to implement the functionality that will use it.
Probably we also need some more refactoring for the whole module in future - e.g. seems that RtcCalInternalOsc is also not available on ESP32-C2
MabezDev
approved these changes
Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unused C6's
enable_8m(), which is used inestimate_xtal_frequency()and we don't have it for C6 yet.Removes a bunch of duplicated C6-related functions.
closes #437