Repository navigation
Unify linker scripts - #443
Merged
Merged
Conversation
- rework original c3 script to use the xtensa named sections (e.g, _SECTIONNAME_start) - Add fixups in esp32c3 specific linker - Remove useless text section start and end (not required when using any form of bootloader)
MabezDev
force-pushed
the
unify-linker-scripts
branch
from
March 20, 2023 13:49
7a6d131 to
8cd4e7f
Compare
MabezDev
force-pushed
the
unify-linker-scripts
branch
from
March 20, 2023 14:17
0b0432d to
2e3d056
Compare
MabezDev
marked this pull request as ready for review
March 20, 2023 15:07
jessebraham
approved these changes
Mar 20, 2023
jessebraham
left a comment
jessebraham
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for taking care of this!
Member
Author
|
With the CI green this is ready for review! If/When we merge this could we please make sure we squash and merge, the commit history is messy, but might be somewhat useful when reviewing. |
MabezDev
added a commit
to MabezDev/esp-hal
that referenced
this pull request
Mar 31, 2023
* esp32 & esp32s2 sharing scripts * add wokwi files * Add fixup section for esp32s2, fix ordering of sectino includes * Remove debug asm file * Use shared linker scripts for s3 with fixups * Add external.x sections back * Move ld scripts into esp-hal-common * esp32c3 unified linker scripts - rework original c3 script to use the xtensa named sections (e.g, _SECTIONNAME_start) - Add fixups in esp32c3 specific linker - Remove useless text section start and end (not required when using any form of bootloader) * Add RTC alias'. Move some shared fixups to a file * comment and cleanup * unify c2 linker script * unify c6 linker script * remove debug configs * use new esp-riscv-rt * fmt * align db symbol names * fix s3 db
i404788
pushed a commit
to i404788/esp-hal
that referenced
this pull request
Jul 22, 2023
* esp32 & esp32s2 sharing scripts * add wokwi files * Add fixup section for esp32s2, fix ordering of sectino includes * Remove debug asm file * Use shared linker scripts for s3 with fixups * Add external.x sections back * Move ld scripts into esp-hal-common * esp32c3 unified linker scripts - rework original c3 script to use the xtensa named sections (e.g, _SECTIONNAME_start) - Add fixups in esp32c3 specific linker - Remove useless text section start and end (not required when using any form of bootloader) * Add RTC alias'. Move some shared fixups to a file * comment and cleanup * unify c2 linker script * unify c6 linker script * remove debug configs * use new esp-riscv-rt * fmt * align db symbol names * fix s3 db
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR doesn't address MCUboot or direct boot, but @bjoernQ has some good ideas in #431 for that.
Adding H2 should hopefully be straight forward and require minimal fixups (just like the C6).