Add PeripheralClockControl argument to timg, wdt, sha, usb-serial-jtag and uart constructors #463
Merged
Merged
Conversation
JurajSadel
force-pushed
the
fix/PeripheralClockControl
branch
from
March 31, 2023 07:21
9c09719 to
619772c
Compare
i404788
pushed a commit
to i404788/esp-hal
that referenced
this pull request
Jul 22, 2023
…ial-jtag` and `uart` constructors (esp-rs#463) * PeripheralClockControl timer * Add PeripheralClockControl to timg, wdt, sha, usb-serial-jtag and uart * ESP32 updated examples * ESP32C2 updated examples * ESP32C3 updated examples * ESP32S2 updated examples * ESP32S3 updated examples * ESP32C6 updated examples * cargo fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not the prettiest PR but the majority of the changes are just because of formatting and I had to change every example.
Now we should have all driver's constructors with the
PeripheralClockControlargument, but it's a breaking change.I'm not sure how to make these changes in a different way. I tested
uart,sha,usb-serial-jtag,timer_interruptandwdtexamples on all chips and everything seems to work fine for me.closes ##410