Started adding ESP32-H2 support #482

playfulFence · 2023-04-18T14:44:22Z

clocks

Implemented all functionality required to get low-level-clocks working
- added esp-hal-common/src/clock/clock_ll/esp32h2, modified clock/mod.rs

esp32h2-hal

created esp32h2-hal package
- updated linker scripts
- ❗ need to update esp-backtrace package link in Cargo.toml after it's merged
❗ README.md needs to be updated

…t H2

…h2` feature

…igure builds, problem with 3 registers

… verified). Next step - test on HW

…nctions

…esp32h2

… irrelevant comments

esp-hal-common/src/rtc_cntl/mod.rs

* get_wakeup_cause: use bitflags instead of cast, & * get_wakeup_cause: bitflags for other cpus

…sync in CI

jessebraham

I still need to review the low-level clock code, and also do some testing and what not, but I've left a handful of comments for now!

esp-hal-common/src/clock/mod.rs

esp-hal-common/src/rtc_cntl/mod.rs

esp-hal-common/src/soc/esp32h2/mod.rs

esp-hal-common/Cargo.toml

Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com>

esp-hal-common/src/clock/clocks_ll/esp32h2.rs

Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com>

jessebraham

Thanks for making all those changes, looking really good! We have a solid base to work from now!

* Update `esp-hal-procmacros` and `esp-hal-smartled` packages to support H2 * Get scaffolding in place to get `esp-hal-common` building with `esp32h2` feature * Made some progress, some aside functions are already done, bbpll configure builds, problem with 3 registers * More progress, all necessary functions are implemented (not every was verified). Next step - test on HW * added bus update to function * add esp32h2-hal package * remove offset for ROM (maybe temporarly) * comment yet unimplemented includes * Provided (COMPLETELY NOT SURE if it's a real solution) * defined interrupt_map_base * fix typo * Implemented boot_defaults and configure functions for clock * Not providing _start_trap_rust_hal to the linker manually now * Typo: delete comment * Cleaning code(1): Removed unnecessary moves, registers, addresses, functions * Remove irrelevant comments * Enable interrupt peripherals * Fix errors, wrong addresses and offsets. Added new CpuClock mode for esp32h2 * Added bus update, enabling and setting i2c mst clk frequency, deleted irrelevant comments * fix CpuControl::start_app_core signature (esp-rs#466) * Minor linker script additions * Use correct linker script comment style * get_wakeup_cause: fix comparison error * Use 192 as mclk_multiple for 24-bit I2S * use bitflags to decode wakeup cause (esp-rs#473) * get_wakeup_cause: use bitflags instead of cast, & * get_wakeup_cause: bitflags for other cpus * rsa peripheral support (esp-rs#467) * Added software interrupt API, examples for all of the MCUs * Added software interrupt API, examples for all of the MCUs * Pin nightly to 2023-03-09 to workaround a problem with embedded-hal-async in CI * Fixed comments * Fixed comments * Fixed comments * Get scaffolding in place to get `esp-hal-common` building with `esp32h2` feature * Updated Cargo.toml * Added esp32h2-hal and other ESP32-H2 to CI workflow * Fix Cargo.toml and add a simple hello_world example * ci: Fix indentation * Update esp-backtrace version in Cargo.toml * Adjust for rustfmt * Adjust for rustfmt * Adjust for rustfmt * Deleted irrelevant comments, fixed wrong i2c_clock frequency * Update esp-hal-common/Cargo.toml Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com> * Populated SocResetReason to get get_wakeup_cause function working * Update esp-hal-common/src/clock/clocks_ll/esp32h2.rs Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com> * PAC has been updated, should be working now --------- Co-authored-by: Jesse Braham <jesse@beta7.io> Co-authored-by: dimpolo <33688001+dimpolo@users.noreply.github.com> Co-authored-by: bjoernQ <bjoern.quentin@mobile-j.de> Co-authored-by: Christopher Liebman <liebman@zod.com> Co-authored-by: Josh Weberruss <joshua.weberruss@gmail.com> Co-authored-by: sreehari prasad <52113972+matrixhead@users.noreply.github.com> Co-authored-by: onsdagens <pawdzi-7@student.ltu.se> Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com> Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com>

jessebraham and others added 19 commits March 31, 2023 07:59

Update esp-hal-procmacros and esp-hal-smartled packages to suppor…

21f9ca4

…t H2

Get scaffolding in place to get esp-hal-common building with `esp32…

60833de

…h2` feature

Made some progress, some aside functions are already done, bbpll conf…

e8e1c75

…igure builds, problem with 3 registers

More progress, all necessary functions are implemented (not every was…

de2ad05

… verified). Next step - test on HW

added bus update to function

2e982bb

add esp32h2-hal package

270dfcf

remove offset for ROM (maybe temporarly)

422ae60

comment yet unimplemented includes

e985f24

Provided (COMPLETELY NOT SURE if it's a real solution)

4a3a052

defined interrupt_map_base

ea86fcc

fix typo

0e53e22

Implemented boot_defaults and configure functions for clock

3c3aa28

Not providing _start_trap_rust_hal to the linker manually now

99def53

Typo: delete comment

eb0cc81

Cleaning code(1): Removed unnecessary moves, registers, addresses, fu…

f27a004

…nctions

Remove irrelevant comments

8f6981a

Enable interrupt peripherals

a5961e1

Fix errors, wrong addresses and offsets. Added new CpuClock mode for …

89994dc

…esp32h2

Added bus update, enabling and setting i2c mst clk frequency, deleted…

e58e44a

… irrelevant comments

SergioGasquez reviewed Apr 18, 2023

View reviewed changes

esp-hal-common/src/rtc_cntl/mod.rs Outdated Show resolved Hide resolved

dimpolo and others added 10 commits April 18, 2023 17:45

fix CpuControl::start_app_core signature (esp-rs#466)

082d333

Minor linker script additions

02ab793

Use correct linker script comment style

62c4b07

get_wakeup_cause: fix comparison error

bee1312

Use 192 as mclk_multiple for 24-bit I2S

dc7a0a5

use bitflags to decode wakeup cause (esp-rs#473)

a503810

* get_wakeup_cause: use bitflags instead of cast, & * get_wakeup_cause: bitflags for other cpus

rsa peripheral support (esp-rs#467)

3e0353c

Added software interrupt API, examples for all of the MCUs

b3e5acc

Added software interrupt API, examples for all of the MCUs

d0c19dd

Pin nightly to 2023-03-09 to workaround a problem with embedded-hal-a…

dec74b0

…sync in CI

playfulFence and others added 7 commits April 18, 2023 19:44

Added esp32h2-hal and other ESP32-H2 to CI workflow

d6f80c3

Fix Cargo.toml and add a simple hello_world example

0e93bce

ci: Fix indentation

aeab263

Update esp-backtrace version in Cargo.toml

f1f72f0

Adjust for rustfmt

6a3c9ab

Adjust for rustfmt

c2b0bfb

Adjust for rustfmt

2755bb7

jessebraham requested changes Apr 20, 2023

View reviewed changes

esp-hal-common/src/clock/mod.rs Outdated Show resolved Hide resolved

esp-hal-common/src/clock/mod.rs Outdated Show resolved Hide resolved

esp-hal-common/src/rtc_cntl/mod.rs Outdated Show resolved Hide resolved

esp-hal-common/src/soc/esp32h2/mod.rs Outdated Show resolved Hide resolved

Deleted irrelevant comments, fixed wrong i2c_clock frequency

d82d74d

jessebraham reviewed Apr 20, 2023

View reviewed changes

esp-hal-common/Cargo.toml Outdated Show resolved Hide resolved

playfulFence and others added 2 commits April 20, 2023 17:11

Update esp-hal-common/Cargo.toml

958eadb

Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com>

Populated SocResetReason to get get_wakeup_cause function working

126566c

jessebraham requested changes Apr 20, 2023

View reviewed changes

esp-hal-common/src/clock/clocks_ll/esp32h2.rs Outdated Show resolved Hide resolved

playfulFence and others added 2 commits April 20, 2023 19:35

Update esp-hal-common/src/clock/clocks_ll/esp32h2.rs

498d07a

Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com>

PAC has been updated, should be working now

658a8af

jessebraham marked this pull request as ready for review April 20, 2023 17:58

jessebraham approved these changes Apr 20, 2023

View reviewed changes

jessebraham merged commit 69060bf into esp-rs:feature/esp32h2 Apr 20, 2023

jessebraham mentioned this pull request Apr 20, 2023

Add support for the ESP32-H2 #224

Closed

5 tasks

playfulFence added a commit to playfulFence/esp-hal that referenced this pull request Apr 26, 2023

Started adding ESP32-H2 support (esp-rs#482)

a2c9051

playfulFence added a commit to playfulFence/esp-hal that referenced this pull request Apr 26, 2023

Started adding ESP32-H2 support (esp-rs#482)

b82089b

playfulFence added a commit to playfulFence/esp-hal that referenced this pull request Apr 26, 2023

Started adding ESP32-H2 support (esp-rs#482)

9929e4c

jessebraham pushed a commit that referenced this pull request Apr 26, 2023

Started adding ESP32-H2 support (#482)

1b8af85

jessebraham pushed a commit to jessebraham/esp-hal that referenced this pull request May 5, 2023

Started adding ESP32-H2 support (esp-rs#482)

c944719

jessebraham pushed a commit to jessebraham/esp-hal that referenced this pull request May 8, 2023

Started adding ESP32-H2 support (esp-rs#482)

9493b38

i404788 pushed a commit to i404788/esp-hal that referenced this pull request Jul 22, 2023

Started adding ESP32-H2 support (esp-rs#482)

0576086

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Started adding ESP32-H2 support #482

Started adding ESP32-H2 support #482

playfulFence commented Apr 18, 2023

jessebraham left a comment

jessebraham left a comment

Started adding ESP32-H2 support #482

Started adding ESP32-H2 support #482

Conversation

playfulFence commented Apr 18, 2023

clocks

esp32h2-hal

jessebraham left a comment

Choose a reason for hiding this comment

jessebraham left a comment

Choose a reason for hiding this comment