Skip to content

Update embedded-hal-async and embassy-* dependencies#488

Merged
jessebraham merged 2 commits into
esp-rs:mainfrom
jessebraham:feature/eh-async
Apr 21, 2023
Merged

Update embedded-hal-async and embassy-* dependencies#488
jessebraham merged 2 commits into
esp-rs:mainfrom
jessebraham:feature/eh-async

Conversation

@jessebraham

@jessebraham jessebraham commented Apr 21, 2023

Copy link
Copy Markdown
Member
  • No changes required for embedded-hal-async, only new traits were added
  • The embassy-executor package now requires two additional features
  • Updated esp-backtrace and esp-println while I was in here, as well

@jessebraham
jessebraham requested a review from bjoernQ April 21, 2023 14:24
@bjoernQ

bjoernQ commented Apr 21, 2023

Copy link
Copy Markdown
Contributor

Thanks for taking care! Maybe it's worth to align the used revision of the executor with esp-rs/esp-wifi-sys#163 (not sure what should align to what)

@jessebraham

Copy link
Copy Markdown
Member Author

Sure, I just went with the latest commit (which seems like a reasonable enough choice to me), but I can change it if there's a reason to.

@bjoernQ

bjoernQ commented Apr 21, 2023

Copy link
Copy Markdown
Contributor

Latest commit sounds good to me - I'll leave a note on that other PR

@bjoernQ bjoernQ left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessebraham
jessebraham merged commit 5c5d7f9 into esp-rs:main Apr 21, 2023
@jessebraham
jessebraham deleted the feature/eh-async branch April 21, 2023 14:49
i404788 pushed a commit to i404788/esp-hal that referenced this pull request Jul 22, 2023
* Update all dependencies to their latest versions

* Update `embassy-executor` and add new required features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants