Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async serial write #510

Merged
merged 4 commits into from
May 5, 2023
Merged

Async serial write #510

merged 4 commits into from
May 5, 2023

Conversation

MabezDev
Copy link
Member

@MabezDev MabezDev commented May 4, 2023

This implements embedded_hal_async::serial::Write for Uart. This is implemented through the FIFO + Interrupts.

In the future (particularly for writes > FIFO size) it will be more efficient to use the DMA.

@MabezDev MabezDev requested review from jessebraham and bjoernQ May 4, 2023 14:27
@MabezDev MabezDev force-pushed the async/serial-write branch 4 times, most recently from 2fd7543 to c4ecd53 Compare May 4, 2023 15:33
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Great we have this now

@MabezDev MabezDev force-pushed the async/serial-write branch from 0c99f04 to 057ac98 Compare May 5, 2023 11:18
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this!

@jessebraham jessebraham merged commit 1731169 into esp-rs:main May 5, 2023
i404788 pushed a commit to i404788/esp-hal that referenced this pull request Jul 22, 2023
* Initial async_{write|flush} implementations

- ESP32C3 + UART0 example

* Support UART1 & UART2

* Add examples for all chips

* reduce number of wakers depending on uart count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants