Async serial write - #510
Merged
Merged
Conversation
MabezDev
force-pushed
the
async/serial-write
branch
4 times, most recently
from
May 4, 2023 15:33
2fd7543 to
c4ecd53
Compare
bjoernQ
approved these changes
May 5, 2023
bjoernQ
left a comment
bjoernQ
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Great we have this now
MabezDev
force-pushed
the
async/serial-write
branch
from
May 5, 2023 11:18
0c99f04 to
057ac98
Compare
jessebraham
approved these changes
May 5, 2023
jessebraham
left a comment
jessebraham
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for taking care of this!
i404788
pushed a commit
to i404788/esp-hal
that referenced
this pull request
Jul 22, 2023
* Initial async_{write|flush} implementations
- ESP32C3 + UART0 example
* Support UART1 & UART2
* Add examples for all chips
* reduce number of wakers depending on uart count
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements
embedded_hal_async::serial::WriteforUart. This is implemented through the FIFO + Interrupts.In the future (particularly for writes > FIFO size) it will be more efficient to use the DMA.