Add async support to the I2C driver#519
Merged
Merged
Conversation
bjoernQ
approved these changes
May 10, 2023
Contributor
bjoernQ
left a comment
bjoernQ
left a comment
There was a problem hiding this comment.
Code looks good to me - however I cannot test it
jessebraham
force-pushed
the
feature/async-i2c
branch
from
1d9e0a8 to
69af59f
Compare
Member
Author
|
Rebased to resolve conflicts |
MabezDev
approved these changes
May 10, 2023
Member
MabezDev
left a comment
MabezDev
left a comment
There was a problem hiding this comment.
Can't test it, but looks good to me! Thanks for taking care of this :)
SergioGasquez
pushed a commit
to SergioGasquez/esp-hal
that referenced
this pull request
Jun 9, 2023
* Small refactor to extract functions for setting up reads/writes * Implement async capabilities for `I2C` driver * Add async I2C examples for each supported chip * Update CHANGELOG
i404788
pushed a commit
to i404788/esp-hal
that referenced
this pull request
Jul 22, 2023
* Small refactor to extract functions for setting up reads/writes * Implement async capabilities for `I2C` driver * Add async I2C examples for each supported chip * Update CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tested all examples on hardware and confirmed they're working. The ESP32-H2 is omitted for now, until
I2Csupport has been added for it.We could probably do some refactoring to reduce code duplication a bit, but that's outside the scope of this PR, IMO.
This is the first async driver I've written so hopefully I've gotten things mostly right 😁