Support for multicore async GPIO: #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
force-pushed
the
async/gpio-multicore
branch
2 times, most recently
from
8aa0a04 to
8b33b02
Compare
bjoernQ
reviewed
May 16, 2023
JurajSadel
reviewed
May 16, 2023
Use the correct registers depending on which core the interrupt is being serviced on. Fixed a bug in the `esp32::gpio_intr` which would enable the interrupt on both cores. It now enables the interrupt for the core in which `listen()` is called.
MabezDev
force-pushed
the
async/gpio-multicore
branch
2 times, most recently
from
237c59f to
e286ca3
Compare
bjoernQ
approved these changes
May 16, 2023
MabezDev
force-pushed
the
async/gpio-multicore
branch
from
e286ca3 to
25951c0
Compare
SergioGasquez
pushed a commit
to SergioGasquez/esp-hal
that referenced
this pull request
Jun 9, 2023
* Support for multicore async GPIO: Use the correct registers depending on which core the interrupt is being serviced on. Fixed a bug in the `esp32::gpio_intr` which would enable the interrupt on both cores. It now enables the interrupt for the core in which `listen()` is called. * add changelog item * Simplify GPIO interrupt status
i404788
pushed a commit
to i404788/esp-hal
that referenced
this pull request
Jul 22, 2023
* Support for multicore async GPIO: Use the correct registers depending on which core the interrupt is being serviced on. Fixed a bug in the `esp32::gpio_intr` which would enable the interrupt on both cores. It now enables the interrupt for the core in which `listen()` is called. * add changelog item * Simplify GPIO interrupt status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the correct registers depending on which core the interrupt is being serviced on. Fixed a bug in the
esp32::gpio_intrwhich would enable the interrupt on both cores. It now enables the interrupt for the core in whichlisten()is called.I didn't add an example, as running the executor on the second core is a bit ugly due to the bounds on
start_app_core(we probably want to take a look at improving this).You can use this example to test it: https://gist.github.com/MabezDev/624738016d8ee67857b96e12253f656f
Closes #539