Repository navigation
Remove a bunch of generic params from GpioPin - #553
Merged
Merged
Conversation
bugadani
marked this pull request as ready for review
May 20, 2023 08:07
Contributor
|
Great idea! 👍 We probably can apply this pattern to other drivers, too 🤔 |
Contributor
Author
|
I haven't used other peripherals yet other than Spi. There, the DMA channel config could maybe be slightly simplified (though I'm not sure about what the SuitablePeripheralX means just yet and if that fits into this or not). |
MabezDev
requested changes
May 22, 2023
MabezDev
left a comment
MabezDev
left a comment
Member
There was a problem hiding this comment.
This is a really nice PR, and definitely something I want to apply to our other type-heavy structures.
Just one small comment to address and this should be ready to go :)
MabezDev
approved these changes
May 22, 2023
SergioGasquez
pushed a commit
to SergioGasquez/esp-hal
that referenced
this pull request
Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
errorsorwarnings. - even the original code had warnings.cargo fmtwas run.CHANGELOG.mdin the proper section.PR description
We had a conversation with @MabezDev over at matrix where he mentioned that ideally GPIOs should have fewer generic parameters. Since their capabilities are tied to the hardware, this PR refactors those generic parameters into a companion trait.