Add a minimal driver for the USB_SERIAL_JTAG peripheral#56
Merged
Conversation
Contributor
|
LGTM - just wondering if we have the FIFO and CONF registers in the PAC? Might be a nice improvement - if not or if it needs too much adjustments we can merge it as is and look into that later |
bjoernQ
approved these changes
May 2, 2022
bjoernQ
left a comment
bjoernQ
left a comment
Contributor
There was a problem hiding this comment.
LGTM - just look at my comment about using the PAC(s)
Member
Author
|
Oh yeah, that makes way more sense. Silly mistake 😁 Thanks for pointing that out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically taken directly from
esp-println, and simply implementscore::fmt::Write. Added some examples as well (though they're almost identical to the existinghello_worldexamples). Test on the C3 and S3.