Simplify the Delay driver, derive Clone and Copy
#568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RISC-V and Xtensa implementations of the delay functionality are both safe to access from multiple contexts, and the `Delay` struct does not take ownership of any peripheral struct, so `Delay` is safe to clone/copy
MabezDev
pushed a commit
to MabezDev/esp-hal
that referenced
this pull request
Jun 1, 2023
* Simplify the `Delay` driver, derive `Clone` and `Copy` The RISC-V and Xtensa implementations of the delay functionality are both safe to access from multiple contexts, and the `Delay` struct does not take ownership of any peripheral struct, so `Delay` is safe to clone/copy * Update the CHANGELOG
SergioGasquez
pushed a commit
to SergioGasquez/esp-hal
that referenced
this pull request
Jun 9, 2023
* Simplify the `Delay` driver, derive `Clone` and `Copy` The RISC-V and Xtensa implementations of the delay functionality are both safe to access from multiple contexts, and the `Delay` struct does not take ownership of any peripheral struct, so `Delay` is safe to clone/copy * Update the CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been recommended by various notable people from the embedded Rust community for quite some time now that delay sources be clone-able. This may also become a requirement of
embedded-halfor theSPIdriver in the future, see here:rust-embedded/embedded-hal#462 (comment)
Since our delay providers do not own any peripheral structs and only perform reads, it's safe to clone/copy as many instances as you would like.