Skip to content

Move esp-riscv-rt into esp-hal #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2023
Merged

Move esp-riscv-rt into esp-hal #578

merged 2 commits into from
Jun 7, 2023

Conversation

MabezDev
Copy link
Member

@MabezDev MabezDev commented Jun 7, 2023

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

jessebraham
jessebraham requested changes Jun 7, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small changes to be made, thanks for taking care of this!

@MabezDev MabezDev force-pushed the move-esp-riscv-rt branch from 657be22 to 69aa61c Compare June 7, 2023 14:55
@MabezDev MabezDev marked this pull request as ready for review June 7, 2023 15:11
@MabezDev MabezDev requested a review from jessebraham June 7, 2023 15:11
jessebraham
jessebraham approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@jessebraham jessebraham merged commit 8361ca3 into esp-rs:main Jun 7, 2023
SergioGasquez pushed a commit to SergioGasquez/esp-hal that referenced this pull request Jun 9, 2023
@MabezDev @SergioGasquez
Move esp-riscv-rt into esp-hal (esp-rs#578)
d9b7f33 
* Move esp-riscv-rt into esp-hal

* Add changelog entry
SergioGasquez pushed a commit to SergioGasquez/esp-hal that referenced this pull request Jun 15, 2023
@MabezDev @SergioGasquez
Move esp-riscv-rt into esp-hal (esp-rs#578)
97a374a 
* Move esp-riscv-rt into esp-hal

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MabezDev @jessebraham