Skip to content

Move esp-riscv-rt into esp-hal - #578

Merged
jessebraham merged 2 commits into
esp-rs:mainfrom
MabezDev:move-esp-riscv-rt
Jun 7, 2023
Merged

jessebraham merged 2 commits into
esp-rs:mainfrom
MabezDev:move-esp-riscv-rt

Conversation

@MabezDev

@MabezDev MabezDev commented Jun 7, 2023

Copy link
Copy Markdown
Member

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

@jessebraham jessebraham left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small changes to be made, thanks for taking care of this!

Comment thread .github/workflows/ci.yml Outdated
Comment thread esp-riscv-rt/Cargo.toml Outdated
@MabezDev
MabezDev force-pushed the move-esp-riscv-rt branch from 657be22 to 69aa61c Compare June 7, 2023 14:55
@MabezDev
MabezDev marked this pull request as ready for review June 7, 2023 15:11
@MabezDev
MabezDev requested a review from jessebraham June 7, 2023 15:11

@jessebraham jessebraham left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@jessebraham
jessebraham merged commit 8361ca3 into esp-rs:main Jun 7, 2023
SergioGasquez pushed a commit to SergioGasquez/esp-hal that referenced this pull request Jun 9, 2023
* Move esp-riscv-rt into esp-hal

* Add changelog entry
SergioGasquez pushed a commit to SergioGasquez/esp-hal that referenced this pull request Jun 15, 2023
* Move esp-riscv-rt into esp-hal

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants