Simplify user-facing DMA channel types #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
channel
branch
5 times, most recently
from
ee88f49 to
3971e96
Compare
This trait is then used to hold types related to the particular DMA channel. This change allows us to simplify user-facing types.
bugadani
changed the title
|
Seems I somehow didn't notice this PR ... LGTM |
SergioGasquez
pushed a commit
to SergioGasquez/esp-hal
that referenced
this pull request
Jun 28, 2023
* Introduce a trait for DMA channels This trait is then used to hold types related to the particular DMA channel. This change allows us to simplify user-facing types. * Remove private type from I2s * Remove redundant spi3 example, update examples * Merge markdown sections * Add changelog entry
MabezDev
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Introduce a trait for DMA channels This trait is then used to hold types related to the particular DMA channel. This change allows us to simplify user-facing types. * Remove private type from I2s * Remove redundant spi3 example, update examples * Merge markdown sections * Add changelog entry
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
* Introduce a trait for DMA channels This trait is then used to hold types related to the particular DMA channel. This change allows us to simplify user-facing types. * Remove private type from I2s * Remove redundant spi3 example, update examples * Merge markdown sections * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to simplify the SpiDma type from
to
This PR also makes the I2s type ascribe-able by the user. Previously, the list of generics included a private type which has been turned into an associated type now.
I have also removed the example introduced in #623 and changed the s3 embassy-spi example to use SPI3.