Merged
Conversation
MabezDev
approved these changes
Jun 9, 2022
Member
MabezDev
left a comment
MabezDev
left a comment
There was a problem hiding this comment.
Looking good to me! PeripheralClockControl is nice, a lot let cfg_if's sprinkled around now - all in one place for the most part.
jessebraham
reviewed
Jun 9, 2022
| /// The existence of this value indicates that the clock configuration can no | ||
| /// longer be changed | ||
| pub struct Clocks { | ||
| _private: (), |
Member
There was a problem hiding this comment.
What is the purpose of this field?
Member
There was a problem hiding this comment.
Without this, the end user would be able to construct Clocks from thin air. This private field means it can only come from the HAL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of #44
While it doesn't allow you to change clock rates, yet it prepares for this by introducing
ClockControll::boot_defaults()i2c_clockwhich doesn't exist - it's because according to the TRM on ESP32 it's always 80MHz and it's not clear to me from where that is ... so, adding this for now seems to be the easiest solution - not ideal but should be okay for nowsystemwhich splits the SYSTEM/DPORT - currently only intoPeripheralClockControlandSystemClockControlSystemClockControl- will be added once we actually allow to change clocksI think this is an improvement in general - definitely more to come however - and I guess this contains enough changes for a single PR