Reading of some eFuses#85
Merged
Merged
Conversation
jessebraham
approved these changes
Jun 17, 2022
Member
jessebraham
left a comment
There was a problem hiding this comment.
This is definitely a great start! I agree with all your points/justifications above, thanks for writing that all out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for reading a few eFuses
Currently there is separate code for each chip - while ESP32 is different the other three ones currently look 100% identical. If we see that the code for those chips doesn't diverge, we can get rid of the copies. But that should be easier than the other way around so I kept it like this for now.
In the old HAL there were also some functions to read ADC calibration data which apparently was used nowhere. After looking into ESP-IDF I think it's more complicated than that and also quite different for different chips. Additionally, there seem to be multiple versions of how the calibration data is stored. That's the main reason I didn't include it here.
Another reason is that I think while reading the raw data should belong here the calculations on top of that probably should go somewhere else.
I'd say we can add more functionality as needed since I cannot make a good guess at what might be useful and what not in the future. Anyway, the basics are there and adding more shouldn't be too hard.