Reading raw ADC data on ESP32 and ESP32-S2#97
Merged
jessebraham merged 1 commit intoesp-rs:mainfrom Jul 7, 2022
Merged
Conversation
jessebraham
approved these changes
Jul 7, 2022
Member
jessebraham
left a comment
There was a problem hiding this comment.
Looks pretty good overall. I think there is probably some refactoring that can be done to reduce duplication a bit, but doesn't really make sense to do that until all implementations are there IMO.
I unfortunately am still unpacking some stuff and I can't find my soldering iron, so I'm unable to attach leads to the potentiometer I found :( I'm sure you tested it but just letting you know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.into_analog()This doesn't implement ADC for ESP32-S3 since our SVD is still missing the
SENSperipheral.ESP32-C3 implementation will be done separately since it's very different and not to blow up this PR too much