Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading raw ADC data on ESP32 and ESP32-S2 #97

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jul 7, 2022

  • implement ADC for ESP32 (basically a port of what ESP32-HAL had)
  • implement ADC for ESP32-S2
    • only works in release mode - no idea why, most probably a codegen issue? Worth to analyze this later
  • prepare ESP32-S3 for analog functions by adding the analog capable pins and .into_analog()

This doesn't implement ADC for ESP32-S3 since our SVD is still missing the SENS peripheral.

ESP32-C3 implementation will be done separately since it's very different and not to blow up this PR too much

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall. I think there is probably some refactoring that can be done to reduce duplication a bit, but doesn't really make sense to do that until all implementations are there IMO.

I unfortunately am still unpacking some stuff and I can't find my soldering iron, so I'm unable to attach leads to the potentiometer I found :( I'm sure you tested it but just letting you know.

@jessebraham jessebraham merged commit 568e37c into esp-rs:main Jul 7, 2022
@bjoernQ bjoernQ deleted the feature/adc branch October 27, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants