Reading raw ADC data on ESP32-C3 - #98
Merged
Merged
Conversation
bjoernQ
force-pushed
the
feature/adc-esp32-c3
branch
from
July 7, 2022 16:03
4443040 to
e56fbf7
Compare
jessebraham
approved these changes
Jul 7, 2022
jessebraham
left a comment
jessebraham
left a comment
Member
There was a problem hiding this comment.
LGTM, but again see my comment in #97 regarding testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds ADC functionality for ESP32-C3. This PR is stacked on #97 so that one needs to get in first
It also re-arranges the analog-functions modules a bit to make it look nicer in docs and also a bit more sane