Skip to content

Reading raw ADC data on ESP32-C3 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jul 7, 2022

This adds ADC functionality for ESP32-C3. This PR is stacked on #97 so that one needs to get in first

It also re-arranges the analog-functions modules a bit to make it look nicer in docs and also a bit more sane

@bjoernQ bjoernQ force-pushed the feature/adc-esp32-c3 branch from 4443040 to e56fbf7 Compare July 7, 2022 16:03
@bjoernQ bjoernQ requested a review from jessebraham July 7, 2022 16:07
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but again see my comment in #97 regarding testing.

@jessebraham jessebraham merged commit 887798f into esp-rs:main Jul 7, 2022
@bjoernQ bjoernQ deleted the feature/adc-esp32-c3 branch October 27, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants