Add some config options to the UART driver#99
Merged
Conversation
jessebraham
reviewed
Jul 11, 2022
jessebraham
left a comment
jessebraham
left a comment
Member
There was a problem hiding this comment.
Left a few review comments, nothing too major. If you don't want to address them now (or ever 😁), that's fine.
As discussed offline it'd be nice to eliminate the NoPin type if possible, that that can be done in subsequent PR(s) if we do move forward with that.
jessebraham
approved these changes
Jul 12, 2022
jessebraham
left a comment
jessebraham
left a comment
Member
There was a problem hiding this comment.
Thank you for addressing my comments, as well as making the changes we discussed yesterday. I think this is looking pretty good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implement configuring the UART / serial driver and adds examples to show how to do that.
Additionally reading never worked on ESP32-S2 - this is fixed now