-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spi/adc_st7789_example #125
Conversation
Added ADC examples |
@monacoprinsen I think it would be great to have an ADC example! Ideally though, examples should be tiny and targeted to demoing just one feature. So I think it would actually be beneficial if you remove the st7789 aspects from this example. (Or create another example, that is only demonstrating how to write on an st7789 screen.) The other thing is, would it be possible to update the example so that it follows the latest changes to the |
@ivmarkov thanks for the input. If you prefer that I remove the St7789 examples I can do that. Should work to update to the latest branch, will do that. |
@monacoprinsen The "St7789 adc" example we should remove, the other two we keep. |
@ivmarkov |
@ivmarkov now it should be up to date. |
Can you make sure that the CI checks pass successfully on your changes? I.e. |
Will do |
@ivmarkov sorry for the delay.... It should be ok now. |
Compile fails. |
@ivmarkov ok will look into that. |
The path to the ferris image seems incorrect? |
@ivmarkov thanks, adjusted it! |
Thank you! |
Added an SPI example, drawing an image on the ST7789 screen.