Add half duplex and 3wire mode support to SPI #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any comment on this ? |
on first glance looks good, did you try out all modes on hardware? i read that the c3 variant does not really have an halve duplex support. maybe need to test that to confirm, else we can use an #[cfg(not(esp32c3))] |
|
@peckpeck Sorry for the delay. The PR is small and clean - if you could only check indeed if half-duplex is supported on the C variants indeed, and |
|
I don't have a C variant to test on, but the espressif programming guide for esp32 C2 and C3 document those flags too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using a config option to busmaster builder