Skip to content

Fix GPIO docstrings#151

Merged
ivmarkov merged 2 commits into
esp-rs:masterfrom
lynaghk:gpio-doc-fix
Oct 29, 2022
Merged

Fix GPIO docstrings#151
ivmarkov merged 2 commits into
esp-rs:masterfrom
lynaghk:gpio-doc-fix

Conversation

@lynaghk

@lynaghk lynaghk commented Oct 22, 2022

Copy link
Copy Markdown
Contributor

Two separate docstring fixes, please see commit messages.

This sets mode to push/pull, not open drain.
…set initial output level.

These methods cannot be called until the pin is already converted into a type which implements OutputMode, and all those functions end up invoking `gpio_set_direction` and thus driving the pin.
@ivmarkov

Copy link
Copy Markdown
Collaborator

Thanks!

@ivmarkov ivmarkov merged commit 59629c8 into esp-rs:master Oct 29, 2022
@lynaghk lynaghk deleted the gpio-doc-fix branch April 2, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants