Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPIO docstrings #151

Merged
merged 2 commits into from
Oct 29, 2022
Merged

Fix GPIO docstrings #151

merged 2 commits into from
Oct 29, 2022

Conversation

lynaghk
Copy link
Contributor

@lynaghk lynaghk commented Oct 22, 2022

Two separate docstring fixes, please see commit messages.

This sets mode to push/pull, not open drain.
…set initial output level.

These methods cannot be called until the pin is already converted into a type which implements OutputMode, and all those functions end up invoking `gpio_set_direction` and thus driving the pin.
@ivmarkov
Copy link
Collaborator

Thanks!

@ivmarkov ivmarkov merged commit 59629c8 into esp-rs:master Oct 29, 2022
@lynaghk lynaghk deleted the gpio-doc-fix branch April 2, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants