Ledc: Add SpeedMode enum, allow lpoint < hpoint < max_duty#155
Merged
Conversation
…tly supported by the chip
MabezDev
approved these changes
Nov 2, 2022
MabezDev
left a comment
MabezDev
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! This is what we do in esp-hal too :).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The high speed mode is only present on
ESP32and it's guarded by a chip featureesp_idf_soc_ledc_support_hs_mode, which gets added during build. The equivalentesp-idfcode.Better than using
esp_idf_sys::ledc_mode_twhich is just ac_uintalias.The ESP supports setting hpoint higher than duty (lpoint), as long as it's below
max_duty., I don't know why I assumed it wasn't so in the prior PR.